add trio.as_safe_channel to async900 safe decorators #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agronholm might want to add a similar decorator to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #370
I thought this was gonna be a one-line fix, but ended up getting really messy. There's definitely a cleaner way of implementing this, but it should work... 🙃
The reason it gets messy is because
has_decorator->_get_identifieronly matches against the last part of an attribute, but I wanttrio.as_safe_decoratorin the error message, so the message and the implementation gets a mismatch. The main alternative approach would be to have separate lists of decorators for the error message and the logic.